java join SQL命令未正确结束

Question

我对join语句有问题

 String q1="select e.employee_id,e.manager_id,e.first_name,e.last_name,e.salary,e.commission_pct,d.manager_id,d.employee_id from employees as e ,employees as d where  e.manager_id=d.employee_id and e.employee_id="+jComboBox1.getSelectedItem();
    try{
        OracleDataSource ods=new OracleDataSource();
        ods.setURL("jdbc:oracle:thin:hr/hr@localhost:1521/XE");
        Connection con=ods.getConnection();

        Statement s=con.createStatement();
        s.execute(q1);
        ResultSet rs=s.getResultSet();
        String x=(String)jComboBox1.getSelectedItem();
        while(rs.next()){
            if (x.equals(rs.getString("e.employee_id"))){
                jTextField1.setText(rs.getString("e.first_name"));
                jTextField2.setText(rs.getString("e.last_name"));
                jTextField3.setText(rs.getString("e.salary"));
                jTextField4.setText(rs.getString("e.commission_pct"));
                jTextField5.setText(rs.getString("d.first_name"));
            }
        }
        con.close();

    }catch(Exception e){e.printStackTrace();}

我怎样才能解决这个问题？！ ....................................................................................................................................................................................................................................

Answer 1

您应该使用prepared语句来避免SQL注入问题。无论如何，你的问题是：

select e.employee_id,e.manager_id,e.first_name,e.last_name,e.salary,e.commission_pct,d.manager_id,d.employee_id 
from employees as e ,employees as d 
where  e.manager_id=d.employee_id 
and e.employee_id="+jComboBox1.getSelectedItem();

我看到您对employee_id使用rs.getString，所以在where子句中缺少对e.employee_id字段的引号