我想向今天没有输入日记账的所有用户发送一封电子邮件。我想让他们在当地时间晚上8点之前输入日志条目,并使其正常工作,但代码非常复杂,我想知道是否有更有效的方法来实现我的目标
我当前保存用户注册时的时区偏移量
<style>
#clientTimezone {
opacity: 0;
width: 0;
float: left;
}
</style>
....
<form class="signup form-default row" id="signup_form" method="post" action="{% url 'account_signup' %}">
{% csrf_token %}
<input type="text" name="client_timezone" id="clientTimezone" required />
....
<script>
$(document).ready(function(){
var d = new Date();
$('#clientTimezone').val(moment().format('ZZ'))
})
</script>
然后,电子邮件代码在我的dailryreminder.py管理命令中,该命令每10分钟触发一次。如果可能的话,我想不用芹菜继续这样做
import arrow
from datetime import datetime, timedelta
from django.utils import timezone
from django.core.management.base import BaseCommand, CommandError
from django.db.models import Q
from django.core.mail import send_mail, send_mass_mail, EmailMultiAlternatives
from django.conf import settings
from dashboard.models import Entry
from dashboard.emails import email_daily_reminder
from redwoodlabs.models import UserProfile
from identity.strings import GLOBAL_STRINGS
LOCAL_TIME_TO_EMAIL = 20 # 8:00 PM
MAX_LOCAL_TIME_TO_EMAIL = 24 # 12:00 AM
USER_BATCH_SIZE = 10
class Command(BaseCommand):
help = 'Email users daily reminder to reflect'
def handle(self, *args, **options):
# UserProfile model has last_notified (datetimefield) and timezone (char field)
# get current time in utc
time_now = arrow.utcnow()
# Get timezone where it's 8PM
start_tz = LOCAL_TIME_TO_EMAIL - time_now.hour
end_tz = MAX_LOCAL_TIME_TO_EMAIL - time_now.hour
# Get a list of timezones where it is between 8pm to 12am
timezones = list()
for tz in range(start_tz, end_tz):
if tz > 14:
tz = 24 - tz
timezones.append('-' + str(tz).zfill(2) + '00')
else:
timezones.append('+' + str(tz).zfill(2) + '00')
time_now_local = time_now.replace(minute=0, second=0)
time_yesterday = time_now.shift(days=-1)
# Get all users with the ff cases:
# - who have not been notified today
# - who have not been notified at all
# - who have not been notified in the last 24hrs
users_to_email = UserProfile.objects.filter(Q(last_notified__isnull=True) |
(Q(timezone__in=timezones) & Q(last_notified__lt=time_now_local.datetime)) |
Q(last_notified__lt=time_yesterday.datetime)
).exclude(timezone__isnull=True)[:USER_BATCH_SIZE]
for profile in users_to_email:
user_time_now = time_now.to(profile.timezone)
user_today = user_time_now.floor('day')
last_notified_day = arrow.get(profile.last_notified).to(profile.timezone)
# Send email if last_notified was before today
if not profile.last_notified or last_notified_day.datetime < user_today.datetime:
self.stdout.write('Notifying %s' % profile)
email_sent = email_daily_reminder(profile.user, user_time_now.date())
# save somewhere they've been notified today?
self.stdout.write(self.style.SUCCESS('Notified %s' % profile.user.email))
profile.last_notified = user_time_now
profile.save()
这是有效的(或者至少到目前为止是有效的),但我想问一下是否有更好的方法(尤其是时区的逻辑),因为我很可能会在不同的项目中再次使用这段代码,并希望学习它的最佳实践。似乎Django有更好的方法来做到这一点
Django有许多database functions可以使您的计算更简单。基本上,您可以尝试的是,用每个用户配置文件的本地时间/小时注释查询集,然后在db级别上执行所有必要的计算,而无需构建时区列表。类似的方法可能会奏效:
在这里,ConvertToTimezone不是Django中可用的db函数,但以下是我以前用于此任务的自定义db函数:
我没有测试这段代码,所以它可能无法立即工作,但应该给您一些关于使用Django的数据库函数简化代码的提示
相关问题 更多 >
编程相关推荐