在Python电话簿examp中实现get\u names和get\u numbers以通过unittest时出现问题

Question

我参加了一个用Python进行单元测试的在线课程，在课程的第一部分，他们使用了一个裸体电话簿作为例子。作为练习，他们希望我们实现两个函数，以便通过以下单元测试

import unittest

from phonebook import Phonebook


class PhonebookTest(unittest.TestCase):

    def setUp(self):
        self.phonebook = Phonebook()

    def test_lookup_entry_by_name(self):
        self.phonebook.add("Bob", "12345")
        self.assertEqual("12345", self.phonebook.lookup("Bob"))

    def test_missing_entry_raises_KeyError(self):
        with self.assertRaises(KeyError):
            self.phonebook.lookup("missing")

    def test_empty_phonebook_is_consistent(self):
        self.assertTrue(self.phonebook.is_consistent())

    def test_phonebook_with_normal_entries_is_consistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "012345")
        self.assertTrue(self.phonebook.is_consistent())

    def test_phonebook_with_duplicate_entries_is_inconsistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "12345")
        self.assertFalse(self.phonebook.is_consistent())

    def test_phonebook_with_numbers_that_prefix_one_another_is_inconsistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "123")
        self.assertFalse(self.phonebook.is_consistent())

    def test_phonebook_adds_names_and_numbers(self):
        phonebook = Phonebook()
        self.phonebook.add("Sue", "12345")
        self.assertIn("Sue", phonebook.get_names())
        self.assertIn("12345", phonebook.get_numbers())

这被放在一个名为test的python文件中_电话簿.py. 两个函数get_names()和get_numbers()放在一个名为电话簿.py. 下面是我的尝试

class Phonebook:

    def __init__(self):
        self.entries = {}

    def add(self, name, number):
        self.entries[name] = number

    def lookup(self, name):
        return self.entries[name]

    def is_consistent(self):
        return self.entries

    def get_names(self):
        return self.entries.keys()

    def get_numbers(self):
        return self.entries.values()

当我尝试在测试上运行unittest时_电话簿.py它以NameError: name 'phonebook' is not defined失败。我不明白为什么会这样。你知道吗

Answer 1

我想您应该先在self.phonebook中实例化phonebook对象，然后再在setUp中实例化，因此您应该使用self.phonebook.get_names()，因为您希望使用类对象来调用类方法，而不是创建自己的phonebook = Phonebook()并使用它。你知道吗

def test_phonebook_adds_names_and_numbers(self):
    #Use self to access phonebook object and associated methods
    self.phonebook.add("Sue", "12345")
    self.assertIn("Sue", self.phonebook.get_names())
    self.assertIn("12345", self.phonebook.get_numbers())

另外，您的其他测试用例也不一致。要检查空字典，您应该assertFalse而不是assertTrue，对于非空字典，您应该assertTrue，修复这些问题，并且上面提到的问题，下面的unittest类应该完美地运行

class PhonebookTest(unittest.TestCase):

    def setUp(self):
        self.phonebook = Phonebook()

    def test_lookup_entry_by_name(self):
        self.phonebook.add("Bob", "12345")
        self.assertEqual("12345", self.phonebook.lookup("Bob"))

    def test_missing_entry_raises_KeyError(self):
        with self.assertRaises(KeyError):
            self.phonebook.lookup("missing")

    def test_empty_phonebook_is_consistent(self):
        self.assertFalse(self.phonebook.is_consistent())

    def test_phonebook_with_normal_entries_is_consistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "012345")
        self.assertTrue(self.phonebook.is_consistent())

    def test_phonebook_with_duplicate_entries_is_inconsistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "12345")
        self.assertTrue(self.phonebook.is_consistent())

    def test_phonebook_with_numbers_that_prefix_one_another_is_inconsistent(self):
        self.phonebook.add("Bob", "12345")
        self.phonebook.add("Mary", "123")
        self.assertTrue(self.phonebook.is_consistent())

    def test_phonebook_adds_names_and_numbers(self):
        self.phonebook.add("Sue", "12345")
        self.assertIn("Sue", self.phonebook.get_names())
        self.assertIn("12345", self.phonebook.get_numbers())

输出为

$ python3.7 -m unittest script.py 
.......
                                   
Ran 7 tests in 0.000s

OK